linux-kernel - Re: [PATCHv2] staging: wilc1000: replace switch statement by simple if condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180320120842.GB4033@hariprasath>
Date:   Tue, 20 Mar 2018 17:38:42 +0530
From:   "<Hariprasath Elango>" <hariprasath.elango@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     hariprasath.elango@...il.com, aditya.shankar@...rochip.com,
        ganesh.krishna@...rochip.com, dan.carpenter@...cle.com,
        gehariprasath@...il.com, linux-wireless@...r.kernel.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2] staging: wilc1000: replace switch statement by simple
 if condition

On Tue, Mar 20, 2018 at 12:47:21PM +0100, Greg KH wrote:
> On Tue, Mar 20, 2018 at 05:13:31PM +0530, hariprasath.elango@...il.com wrote:
> > From: HariPrasath Elango <hariprasath.elango@...il.com>
> > 
> > In this case,there is only a single switch case statement.So replacing
> > by a simple if condition
> > 
> > Signed-off-by: HariPrasath Elango <hariprasath.elango@...il.com>
> > ---
> >  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 +-------
> >  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> What changed from v1?  Always put that information below the --- line,
> like the kernel documentation asks you to do.
> 
> v3?  :)
> 
> thanks,
> 
> greg k-h

Lesson learned. I will send a v3 with version history included

regards,
hari prasath