linux-kernel - Re: [PATCH] staging: typec: rt1711h typec chip driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa838cdd-6333-68fc-0ead-8ad9e7fd8ff9@gmail.com>
Date:   Fri, 16 Mar 2018 14:29:41 +0100
From:   Mats Karrman <mats.dev.list@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        ShuFan Lee <leechu729@...il.com>
Cc:     heikki.krogerus@...ux.intel.com, linux@...ck-us.net,
        shufan_lee@...htek.com, cy_huang@...htek.com, jun.li@....com,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] staging: typec: rt1711h typec chip driver

Hi,

On 2018-03-16 13:58, Greg KH wrote:

> On Fri, Mar 16, 2018 at 05:12:49PM +0800, ShuFan Lee wrote:
>> From: ShuFan Lee <shufan_lee@...htek.com>
>>
>> Richtek RT1711H Type-C chip driver that works with
>> Type-C Port Controller Manager to provide USB PD and
>> USB Type-C functionalities.
>> Add definition of TCPC_CC_STATUS_TOGGLING.
>>
>> Signed-off-by: ShuFan Lee <shufan_lee@...htek.com>
>> ---
>>   drivers/staging/typec/Kconfig         |   8 +
>>   drivers/staging/typec/Makefile        |   1 +
>>   drivers/staging/typec/tcpci.h         |   1 +
>>   drivers/staging/typec/tcpci_rt1711h.c | 344 ++++++++++++++++++++++++++++++++++
>>   4 files changed, 354 insertions(+)
>>   create mode 100644 drivers/staging/typec/tcpci_rt1711h.c
> This looks nice and simple to me, any reason it has to live in
> drivers/staging/ and we can't just move it to drivers/usb/typec/ now?
>
> Or are there still api things that need to be resolved with the existing
> drivers/staging/typec/ code?

For one thing it depends on the tcpci driver that is still in staging until Jun Li's patches, [1], comes through.

// Mats

[1] https://marc.info/?l=linux-usb&m=152093458605648&w=2

> thanks,
>
> greg k-h
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>