lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20180317.200513.1916546646223366804.davem@davemloft.net> Date: Sat, 17 Mar 2018 20:05:13 -0400 (EDT) From: David Miller <davem@...emloft.net> To: doshir@...are.com Cc: netdev@...r.kernel.org, rachel_lunnon@...rmagic.com, skhare@...are.com, pv-drivers@...are.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 net 2/2] vmxnet3: use correct flag to indicate LRO feature From: Ronak Doshi <doshir@...are.com> Date: Fri, 16 Mar 2018 14:49:19 -0700 > 'Commit 45dac1d6ea04 ("vmxnet3: Changes for vmxnet3 adapter version 2 > (fwd)")' introduced a flag "lro" in structure vmxnet3_adapter which is > used to indicate whether LRO is enabled or not. However, the patch > did not set the flag and hence it was never exercised. > > So, when LRO is enabled, it resulted in poor TCP performance due to > delayed acks. This issue is seen with packets which are larger than > the mss getting a delayed ack rather than an immediate ack, thus > resulting in high latency. > > This patch removes the lro flag and directly uses device features > against NETIF_F_LRO to check if lro is enabled. > > Fixes: 45dac1d6ea04 ("vmxnet3: Changes for vmxnet3 adapter version 2 (fwd)") > Reported-by: Rachel Lunnon <rachel_lunnon@...rmagic.com> > Signed-off-by: Ronak Doshi <doshir@...are.com> > Acked-by: Shrikrishna Khare <skhare@...are.com> Applied.
Powered by blists - more mailing lists