linux-kernel - Re: [PATCH v2 1/2] mtd: maps: Remove print after allocation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Mar 2018 23:42:50 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Arushi Singhal <arushisinghal19971997@...il.com>
Cc:     boris.brezillon@...e-electrons.com, richard@....at,
        dwmw2@...radead.org, computersforpeace@...il.com,
        nicolas.ferre@...rochip.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, miquel.raynal@...e-electrons.com,
        alexandre.belloni@...e-electrons.com, wens@...e.org,
        cyrille.pitchen@...ev4u.fr
Subject: Re: [PATCH v2 1/2] mtd: maps: Remove print after allocation failure

Hi Arushi,

On Sun, 18 Mar 2018 22:03:15 +0530, Arushi Singhal
<arushisinghal19971997@...il.com> wrote:

> The prints after [k|v][m|z|c]alloc() functions are not needed, because
> in case of failure, allocator will print their internal error prints
> anyway.
> 
> Signed-off-by: Arushi Singhal <arushisinghal19971997@...il.com>
> ---
> changes in v2
> * done changes in all the other files.
> 
>  drivers/mtd/maps/amd76xrom.c  | 6 ++----
>  drivers/mtd/maps/ck804xrom.c  | 4 +---
>  drivers/mtd/maps/esb2rom.c    | 4 +---
>  drivers/mtd/maps/ichxrom.c    | 6 ++----
>  drivers/mtd/maps/sun_uflash.c | 4 +---
>  drivers/mtd/maps/vmu-flash.c  | 3 ---
>  6 files changed, 7 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/mtd/maps/amd76xrom.c b/drivers/mtd/maps/amd76xrom.c
> index 26de0a1..406a8d3 100644
> --- a/drivers/mtd/maps/amd76xrom.c
> +++ b/drivers/mtd/maps/amd76xrom.c
> @@ -188,10 +188,8 @@ static int amd76xrom_init_one(struct pci_dev *pdev,
>  
>  		if (!map) {
>  			map = kmalloc(sizeof(*map), GFP_KERNEL);
> -		}
> -		if (!map) {
> -			printk(KERN_ERR MOD_NAME ": kmalloc failed");
> -			goto out;
> +			if (!map)
> +				goto out;
>  		}
>  		memset(map, 0, sizeof(*map));
>  		INIT_LIST_HEAD(&map->list);
> diff --git a/drivers/mtd/maps/ck804xrom.c b/drivers/mtd/maps/ck804xrom.c
> index 584962e..2529d1b 100644
> --- a/drivers/mtd/maps/ck804xrom.c
> +++ b/drivers/mtd/maps/ck804xrom.c
> @@ -219,10 +219,8 @@ static int __init ck804xrom_init_one(struct pci_dev *pdev,
>  		if (!map)
>  			map = kmalloc(sizeof(*map), GFP_KERNEL);
>  
> -		if (!map) {
> -			printk(KERN_ERR MOD_NAME ": kmalloc failed");
> +		if (!map)
>  			goto out;
> -		}

This is a personal feeling but I prefer the first version:

        if (!map) {
                map = kmalloc();
                if (!map)
                        err;
        }

than

        if (!map)
                map = kmalloc();

        if (!map)
                err;

Same below of course.


Thanks,
Miquèl

-- 
Miquel Raynal, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com