linux-kernel - Re: [PATCH v2 2/2] mtd: nand: Remove print after allocation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180319234729.73fb800d@xps13>
Date:   Mon, 19 Mar 2018 23:47:29 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Arushi Singhal <arushisinghal19971997@...il.com>
Cc:     boris.brezillon@...e-electrons.com, richard@....at,
        dwmw2@...radead.org, computersforpeace@...il.com,
        nicolas.ferre@...rochip.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, miquel.raynal@...e-electrons.com,
        alexandre.belloni@...e-electrons.com, wens@...e.org,
        cyrille.pitchen@...ev4u.fr
Subject: Re: [PATCH v2 2/2] mtd: nand: Remove print after allocation failure

Hi Arushi,

On Sun, 18 Mar 2018 22:03:16 +0530, Arushi Singhal
<arushisinghal19971997@...il.com> wrote:

> The prints after [k|v][m|z|c]alloc() etc. functions are not needed, because
> in case of failure, allocator will print their internal error prints
> anyway.
> 
> Signed-off-by: Arushi Singhal <arushisinghal19971997@...il.com>
> ---
> changes in v2
> *done the similar changes in other files.
> 
>  drivers/mtd/nand/ams-delta.c             |  1 -
>  drivers/mtd/nand/atmel/nand-controller.c | 13 +++---------
>  drivers/mtd/nand/marvell_nand.c          |  8 ++------
>  drivers/mtd/nand/nandsim.c               | 35 ++++++++------------------------
>  drivers/mtd/nand/ndfc.c                  |  4 +---
>  drivers/mtd/nand/sunxi_nand.c            |  4 +---
>  6 files changed, 15 insertions(+), 50 deletions(-)
> 


Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>

Thanks,
Miquèl

-- 
Miquel Raynal, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com