linux-kernel - Re: [PATCH 3/4] Bluetooth: trailing statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <49319155-4ADA-4913-8177-B4E2AE1D83EA@holtmann.org>
Date:   Tue, 20 Mar 2018 09:09:31 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Paul McQuade <paulmcquad@...il.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] Bluetooth: trailing statements

Hi Paul,

> trailing statements should be on next line
> 
> Signed-off-by: Paul McQuade <paulmcquad@...il.com>
> ---
> drivers/bluetooth/hci_ll.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c
> index 1b4417a623a4..06d859d82de8 100644
> --- a/drivers/bluetooth/hci_ll.c
> +++ b/drivers/bluetooth/hci_ll.c
> @@ -567,7 +567,8 @@ static int read_local_version(struct hci_dev *hdev)
> 	version = le16_to_cpu(ver->lmp_subver);
> 
> out:
> -	if (err) bt_dev_err(hdev, "Failed to read TI version info: %d", err);
> +	if (err)
> +	bt_dev_err(hdev, "Failed to read TI version info: %d", err);

actually this needs to be indented one further since it is the action of the if clause.

Regards

Marcel