linux-kernel - Re: [PATCH 1/4] Bluetooth: trailing whitespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <99F8EAD7-D1F7-4697-9188-E657D6CC33B0@holtmann.org>
Date:   Tue, 20 Mar 2018 09:10:28 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Paul McQuade <paulmcquad@...il.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] Bluetooth: trailing whitespace

Hi Paul,

> Removed whitespace
> 
> Signed-off-by: Paul McQuade <paulmcquad@...il.com>
> ---
> drivers/bluetooth/bfusb.c     | 2 +-
> drivers/bluetooth/btuart_cs.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c
> index ab090a313a5f..0d5b403fe431 100644
> --- a/drivers/bluetooth/bfusb.c
> +++ b/drivers/bluetooth/bfusb.c
> @@ -148,7 +148,7 @@ static int bfusb_send_bulk(struct bfusb_data *data, struct sk_buff *skb)
> 
> 	err = usb_submit_urb(urb, GFP_ATOMIC);
> 	if (err) {
> -		BT_ERR("%s bulk tx submit failed urb %p err %d", 
> +		BT_ERR("%s bulk tx submit failed urb %p err %d",
> 					data->hdev->name, urb, err);
> 		skb_unlink(skb, &data->pending_q);
> 		usb_free_urb(urb);
> diff --git a/drivers/bluetooth/btuart_cs.c b/drivers/bluetooth/btuart_cs.c
> index 310e9c2e09b6..8dce5bfad947 100644
> --- a/drivers/bluetooth/btuart_cs.c
> +++ b/drivers/bluetooth/btuart_cs.c
> @@ -365,10 +365,10 @@ static void btuart_change_speed(struct btuart_info *info,
> 
> 	fcr = UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT;
> 
> -	/* 
> +	/*
> 	 * Use trigger level 1 to avoid 3 ms. timeout delay at 9600 bps, and
> 	 * almost 1,7 ms at 19200 bps. At speeds above that we can just forget
> -	 * about this timeout since it will always be fast enough. 
> +	 * about this timeout since it will always be fast enough.
> 	 */

drop the btuart_cs. change since I will be removing that driver. It is not bound to any hardware anyway and thus just some legacy that has been left around.

Regards

Marcel