linux-kernel - Re: [v2 PATCH 5/5] Staging:rtl8723bs clean spaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1521577955.12047.26.camel@perches.com>
Date:   Tue, 20 Mar 2018 13:32:35 -0700
From:   Joe Perches <joe@...ches.com>
To:     Paul McQuade <paulmcquad@...il.com>
Cc:     gregkh@...uxfoundation.org, davem@...emloft.net,
        stephen@...workplumber.org, Linyu.Yuan@...atel-sbell.com.cn,
        Larry.Finger@...inger.net, keescook@...omium.org,
        hdegoede@...hat.com, johannes.berg@...el.com,
        colin.king@...onical.com, arvind.yadav.cs@...il.com, arnd@...db.de,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [v2 PATCH 5/5] Staging:rtl8723bs clean spaces

On Tue, 2018-03-20 at 20:26 +0000, Paul McQuade wrote:
> Used checkpatch.pl to clean up spaces around if and for statements
> to make it easier to read

Perhaps the commit message can be made clearer.

I think this is technically correct, but it would
be nicer to describe these changes as moving braces
to the more common kernel-style locations.

> diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
[]
> @@ -20,8 +20,7 @@
>  
>  void rtw_os_free_recvframe(union recv_frame *precvframe)
>  {
> -	if (precvframe->u.hdr.pkt)
> -	{
> +	if (precvframe->u.hdr.pkt) {
>  		dev_kfree_skb_any(precvframe->u.hdr.pkt);/* free skb by driver */
>  
>  		precvframe->u.hdr.pkt = NULL;