linux-kernel - Re: [PATCH V2 1/4] clk: bulk: add of_clk_bulk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <152182399342.178046.13139513462419815903@swboyd.mtv.corp.google.com>
Date:   Fri, 23 Mar 2018 09:53:13 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Dong Aisheng <aisheng.dong@....com>, linux-clk@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        mturquette@...libre.com, hdegoede@...hat.com,
        b.zolnierkie@...sung.com, linux@...linux.org.uk,
        linux-fbdev@...r.kernel.org, linux-imx@....com,
        Dong Aisheng <aisheng.dong@....com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Russell King <linux@....linux.org.uk>
Subject: Re: [PATCH V2 1/4] clk: bulk: add of_clk_bulk_get()

Quoting Dong Aisheng (2018-03-20 20:19:48)
> diff --git a/drivers/clk/clk-bulk.c b/drivers/clk/clk-bulk.c
> index 4c10456..4b357b2 100644
> --- a/drivers/clk/clk-bulk.c
> +++ b/drivers/clk/clk-bulk.c
> @@ -19,6 +19,38 @@
>  #include <linux/clk.h>
>  #include <linux/device.h>
>  #include <linux/export.h>
> +#include <linux/of.h>
> +
> +#if defined(CONFIG_OF) && defined(CONFIG_COMMON_CLK)

Do we need these defines? of_clk_get() is a stub function when these
configs are false.

> +static int __must_check of_clk_bulk_get(struct device_node *np, int num_clks,
> +                                       struct clk_bulk_data *clks)
> +{
> +       int ret;
> +       int i;
> +
> +       for (i = 0; i < num_clks; i++)
> +               clks[i].clk = NULL;
> +
> +       for (i = 0; i < num_clks; i++) {
> +               clks[i].clk = of_clk_get(np, i);
> +               if (IS_ERR(clks[i].clk)) {
> +                       ret = PTR_ERR(clks[i].clk);
> +                       pr_err("%pOF: Failed to get clk index: %d ret: %d\n",
> +                              np, i, ret);
> +                       clks[i].clk = NULL;
> +                       goto err;
> +               }
> +       }
> +
> +       return 0;
> +
> +err:
> +       clk_bulk_put(i, clks);
> +
> +       return ret;
> +}
> +EXPORT_SYMBOL(of_clk_bulk_get);

It's static, so don't export it.