linux-kernel - Re: [PATCH for-4.16 2/3] drivers: change struct device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180323165543.GA21833@kroah.com>
Date:   Fri, 23 Mar 2018 17:55:43 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Arend van Spriel <aspriel@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Brian Norris <briannorris@...omium.org>
Subject: Re: [PATCH for-4.16 2/3] drivers: change struct
 device_driver::coredump() return type to void

On Thu, Mar 15, 2018 at 10:55:24AM +0100, Arend van Spriel wrote:
> Upon submitting a patch for mwifiex [1] it was discussed whether this
> callback function could fail. To keep things simple there is no need
> for the error code so the driver can do the task synchronous or not
> without worries. Currently the device driver core already ignores the
> return value so changing it to void.
> 
> [1] https://patchwork.kernel.org/patch/10231933/
> 
> Signed-off-by: Arend van Spriel <aspriel@...il.com>
> ---
>  include/linux/device.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/device.h b/include/linux/device.h
> index b093405..f08c25b 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -256,6 +256,9 @@ enum probe_type {
>   *		automatically.
>   * @pm:		Power management operations of the device which matched
>   *		this driver.
> + * @coredump:	Called when sysfs entry is written to. The device driver
> + *		is expected to call the dev_coredump API resulting in a
> + *		uevent.
>   * @p:		Driver core's private data, no one other than the driver
>   *		core can touch this.
>   *
> @@ -287,7 +290,7 @@ struct device_driver {
>  	const struct attribute_group **groups;
> 
>  	const struct dev_pm_ops *pm;
> -	int (*coredump) (struct device *dev);
> +	void (*coredump) (struct device *dev);

Isn't this going to cause build warnings now?  Are there no users of
this callback function yet?

thanks,

greg k-h