linux-kernel - Re: [2/4] scsi: hpsa: Less function calls in hpsa_big_passthru

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <a1e4dcf0-22fa-0b9b-a111-56beac441b24@users.sourceforge.net>
Date:   Sat, 24 Mar 2018 10:01:07 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Don Brace <don.brace@...rosemi.com>, linux-scsi@...r.kernel.org,
        esc.storagedev@...rosemi.com
Cc:     "James E. J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [2/4] scsi: hpsa: Less function calls in
 hpsa_big_passthru_ioctl() after error detection

>> @@ -6501,14 +6501,16 @@ static int hpsa_big_passthru_ioctl(struct ctlr_info
>> *h, void __user *argp)
>>  cleanup0:
>>         cmd_free(h, c);
>>  cleanup1:
>> -       if (buff) {
>> +       {
>>                 int i;
>>
>>                 for (i = 0; i < sg_used; i++)
>>                         kfree(buff[i]);
>>                 kfree(buff);
>>         }
> 
> Thanks for looking at the hpsa driver.
> 
> This HUNK ends up with an unnamed block.

Which identifier would you like to use there?


> I would prefer to not have it structured like this.

Would you like to show a source code layout alternative?

Regards,
Markus