linux-kernel - Re: [PATCH v2] mm/page_owner: ignore everything below the IRQ entry point

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Mar 2018 12:52:28 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     v.narang@...sung.com
Cc:     Dmitry Vyukov <dvyukov@...gle.com>,
        Maninder Singh <maninder1.s@...sung.com>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Alexander Potapenko <glider@...gle.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Michal Hocko <mhocko@...e.com>,
        "vinmenon@...eaurora.org" <vinmenon@...eaurora.org>,
        "gomonovych@...il.com" <gomonovych@...il.com>,
        Ayush Mittal <ayush.m@...sung.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kasan-dev <kasan-dev@...glegroups.com>,
        Linux-MM <linux-mm@...ck.org>,
        AMIT SAHRAWAT <a.sahrawat@...sung.com>,
        PANKAJ MISHRA <pankaj.m@...sung.com>
Subject: Re: [PATCH v2] mm/page_owner: ignore everything below the IRQ entry
 point

On Mon, 26 Mar 2018 19:47:17 +0530 Vaneet Narang <v.narang@...sung.com> wrote:

> Hi Dmitry,
> 
> >Every user of stack_depot should filter out irq frames, without that
> >stack_depot will run out of memory sooner or later. so this is a
> >change in the right direction.
> > 
> >Do we need to define empty version of in_irqentry_text? Shouldn't only
> >filter_irq_stacks be used by kernel code?
> 
> We thought about this but since we were adding both the APIs filter_irq_stacks & in_irqentry_text 
> in header file so we thought of defining empty definition for both as both the APIs are accessible
> to the module who is going to include header file.
> 
> If you think empty definition of in_irqentry_text() is not requited then we will modify & resend the
> patch.
> 

filter_irq_stacks() is too large to be inlined.

The CONFIG_STACKTRACE=n versions should be regular C functions, not
macros.  But stacktrace.c decided to do them all as macros,
unfortunately.

in_irqentry_text() is probably too large to be inlined as well, and
should return bool.

Declarations for __irqentry_text_start and friends already exist in
include/asm-generic/sections.h (and, for some reason, also in
arch/arm/include/asm/traps.h) and should not be duplicated in
include/linux/stacktrace.h.