linux-kernel - Re: [PATCH v2] mm/page_owner: ignore everything below the IRQ entry point

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180327114019epcms5p41dec80bebd551f85f576d90ff144fba8@epcms5p4>
Date:   Tue, 27 Mar 2018 17:10:19 +0530
From:   Maninder Singh <maninder1.s@...sung.com>
To:     Andrew Morton <akpm@...ux-foundation.org>,
        Vaneet Narang <v.narang@...sung.com>
CC:     Dmitry Vyukov <dvyukov@...gle.com>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Alexander Potapenko <glider@...gle.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Michal Hocko <mhocko@...e.com>,
        "vinmenon@...eaurora.org" <vinmenon@...eaurora.org>,
        "gomonovych@...il.com" <gomonovych@...il.com>,
        Ayush Mittal <ayush.m@...sung.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kasan-dev <kasan-dev@...glegroups.com>,
        Linux-MM <linux-mm@...ck.org>,
        AMIT SAHRAWAT <a.sahrawat@...sung.com>,
        PANKAJ MISHRA <pankaj.m@...sung.com>
Subject: Re: [PATCH v2] mm/page_owner: ignore everything below the IRQ entry
 point

Hi Andrew,

>filter_irq_stacks() is too large to be inlined.
 
Ok we are thinking to move definations in kernel/stacktrace.c
as a normal global function.
 

>in_irqentry_text() is probably too large to be inlined as well, and
>should return bool.

We can declare it as static funciton in kernel/stacktrace.c as its user
is only filter_irq_stacks.
 
>Declarations for __irqentry_text_start and friends already exist in
>include/asm-generic/sections.h (and, for some reason, also in
>arch/arm/include/asm/traps.h) and should not be duplicated in
>include/linux/stacktrace.h.

Ok, done.

Sending new patch with fixes.

Thanks.
Maninder Singh