linux-kernel - Re: [PATCH] RDMA/hns: ensure for-loop actually iterates and free's buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180327210803.GA26189@ziepe.ca>
Date:   Tue, 27 Mar 2018 15:08:03 -0600
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Colin Ian King <colin.king@...onical.com>
Cc:     Lijun Ou <oulijun@...wei.com>, Wei Hu <xavier.huwei@...wei.com>,
        Doug Ledford <dledford@...hat.com>, linux-rdma@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/hns: ensure for-loop actually iterates and free's
 buffers

On Mon, Mar 26, 2018 at 04:10:18PM +0100, Colin Ian King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The current for-loop zeros variable i and only loops once, hence
> not all the buffers are free'd.  Fix this by setting i correctly.
> 
> Detected by CoverityScan, CID#1463415 ("Operands don't affect result")
> 
> Fixes: a5073d6054f7 ("RDMA/hns: Add eq support of hip08")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> Reviewed-by: Yixian Liu <liuyixian@...wei.com>
> ---
>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-rc, thanks

Jason