linux-kernel - Re: [PATCH] RDMA/hns: ensure for-loop actually iterates and free's buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed57c631-94ec-82ad-8621-12f36bb017e1@huawei.com>
Date:   Tue, 27 Mar 2018 15:14:36 +0800
From:   "Liuyixian (Eason)" <liuyixian@...wei.com>
To:     Colin King <colin.king@...onical.com>,
        Lijun Ou <oulijun@...wei.com>,
        "Wei Hu" <xavier.huwei@...wei.com>,
        Doug Ledford <dledford@...hat.com>,
        "Jason Gunthorpe" <jgg@...pe.ca>, <linux-rdma@...r.kernel.org>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] RDMA/hns: ensure for-loop actually iterates and free's
 buffers



On 2018/3/26 23:10, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The current for-loop zeros variable i and only loops once, hence
> not all the buffers are free'd.  Fix this by setting i correctly.

Hi Colin,

Thank you very much for this patch! It's a typo when I prepared the patch set.

Reviewed-by: Yixian Liu <liuyixian@...wei.com>

> 
> Detected by CoverityScan, CID#1463415 ("Operands don't affect result")
> 
> Fixes: a5073d6054f7 ("RDMA/hns: Add eq support of hip08")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> index 684c2d1a0ed0..8b84ab7800d8 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> @@ -4391,7 +4391,7 @@ static int hns_roce_mhop_alloc_eq(struct hns_roce_dev *hr_dev,
>  	eq->l0_dma = 0;
>  
>  	if (mhop_num == 1)
> -		for (i -= i; i >= 0; i--)
> +		for (i -= 1; i >= 0; i--)
>  			dma_free_coherent(dev, buf_chk_sz, eq->buf[i],
>  					  eq->buf_dma[i]);
>  	else if (mhop_num == 2) {
>