linux-kernel - Re: [PATCH v2 2/2] dt-bindings: phy-qcom-qmp: Add UFS phy compitable string for sdm845

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb8740302ee88c920811802c11306f70@codeaurora.org>
Date:   Tue, 27 Mar 2018 15:13:15 +0800
From:   cang@...eaurora.org
To:     Vivek Gautam <vivek.gautam@...eaurora.org>
Cc:     subhashj@...eaurora.org, asutoshd@...eaurora.org,
        mgautam@...eaurora.org, kishon@...com, robh+dt@...nel.org,
        mark.rutland@....com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: phy-qcom-qmp: Add UFS phy compitable
 string for sdm845

On 2018-03-26 23:00, Vivek Gautam wrote:
> On 3/21/2018 11:07 AM, Can Guo wrote:
>> Update the compatible string for UFS QMP PHY on SDM845.
>> 
>> Signed-off-by: Can Guo <cang@...eaurora.org>
>> ---
>>   Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt 
>> b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
>> index cef8765..6e68a6d 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
>> +++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
>> @@ -11,7 +11,8 @@ Required properties:
>>   	       "qcom,msm8996-qmp-usb3-phy" for 14nm USB3 phy on msm8996,
>>   	       "qcom,qmp-v3-usb3-phy" for USB3 QMP V3 phy,
>>   	       "qcom,sdm845-qmp-usb3-phy" for USB3 QMP V3 phy on sdm845,
>> -	       "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on 
>> sdm845.
>> +	       "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on 
>> sdm845,
>> +	       "qcom,sdm845-qmp-ufs-phy" for UFS QMP phy on sdm845.
> 
> We also need an entry for 'ref_aux' clock in the clock names for this 
> phy.
> Please add that.
> With that,
> Reviewed-by: Vivek Gautam <vivek.gautam@...eaurora.org>
> 
> Thanks
> Vivek.
> 

I realized that 'ref_aux' is not needed in the driver, shall remove it 
from the PHY driver.

Thanks
Can.

>>      - reg: offset and length of register set for PHY's common serdes 
>> block.
>>