linux-kernel - Re: [PATCH] staging: fsl-dpaa2/ethsw: Fix TCI values overwrite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201803281742.tG0RbUpR%fengguang.wu@intel.com>
Date:   Wed, 28 Mar 2018 18:15:32 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Razvan Stefanescu <razvan.stefanescu@....com>
Cc:     kbuild-all@...org, gregkh@...uxfoundation.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, andrew@...n.ch,
        alexandru.marginean@....com, ruxandra.radulescu@....com,
        ioana.ciornei@....com, laurentiu.tudor@....com, stuyoder@...il.com
Subject: Re: [PATCH] staging: fsl-dpaa2/ethsw: Fix TCI values overwrite

Hi Razvan,

I love your patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on next-20180327]
[cannot apply to v4.16-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Razvan-Stefanescu/staging-fsl-dpaa2-ethsw-Fix-TCI-values-overwrite/20180328-154703
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   drivers/staging/fsl-dpaa2/ethsw/dpsw.c: In function 'dpsw_if_get_tci':
>> drivers/staging/fsl-dpaa2/ethsw/dpsw.c:547:9: error: variable 'cmd' has initializer but incomplete type
     struct mc_command cmd = { 0 };
            ^~~~~~~~~~
>> drivers/staging/fsl-dpaa2/ethsw/dpsw.c:547:28: warning: excess elements in struct initializer
     struct mc_command cmd = { 0 };
                               ^
   drivers/staging/fsl-dpaa2/ethsw/dpsw.c:547:28: note: (near initialization for 'cmd')
>> drivers/staging/fsl-dpaa2/ethsw/dpsw.c:547:20: error: storage size of 'cmd' isn't known
     struct mc_command cmd = { 0 };
                       ^~~
   drivers/staging/fsl-dpaa2/ethsw/dpsw.c:547:20: warning: unused variable 'cmd' [-Wunused-variable]

vim +/cmd +547 drivers/staging/fsl-dpaa2/ethsw/dpsw.c

   530	
   531	/**
   532	 * dpsw_if_get_tci() - Get default VLAN Tag Control Information (TCI)
   533	 * @mc_io:	Pointer to MC portal's I/O object
   534	 * @cmd_flags:	Command flags; one or more of 'MC_CMD_FLAG_'
   535	 * @token:	Token of DPSW object
   536	 * @if_id:	Interface Identifier
   537	 * @cfg:	Tag Control Information Configuration
   538	 *
   539	 * Return:	Completion status. '0' on Success; Error code otherwise.
   540	 */
   541	int dpsw_if_get_tci(struct fsl_mc_io *mc_io,
   542			    u32 cmd_flags,
   543			    u16 token,
   544			    u16 if_id,
   545			    struct dpsw_tci_cfg *cfg)
   546	{
 > 547		struct mc_command cmd = { 0 };
   548		struct dpsw_cmd_if_get_tci *cmd_params;
   549		struct dpsw_rsp_if_get_tci *rsp_params;
   550		int err;
   551	
   552		/* prepare command */
   553		cmd.header = mc_encode_cmd_header(DPSW_CMDID_IF_GET_TCI,
   554						  cmd_flags,
   555						  token);
   556		cmd_params = (struct dpsw_cmd_if_get_tci *)cmd.params;
   557		cmd_params->if_id = cpu_to_le16(if_id);
   558	
   559		/* send command to mc*/
   560		err = mc_send_command(mc_io, &cmd);
   561		if (err)
   562			return err;
   563	
   564		/* retrieve response parameters */
   565		rsp_params = (struct dpsw_rsp_if_get_tci *)cmd.params;
   566		cfg->pcp = rsp_params->pcp;
   567		cfg->dei = rsp_params->dei;
   568		cfg->vlan_id = le16_to_cpu(rsp_params->vlan_id);
   569	
   570		return 0;
   571	}
   572	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (62898 bytes)