linux-kernel - Re: [PATCH] amdkfd: always select MMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Mar 2018 18:04:33 +0200
From:   Christian König <christian.koenig@....com>
To:     Arnd Bergmann <arnd@...db.de>, Oded Gabbay <oded.gabbay@...il.com>,
        Alex Deucher <alexander.deucher@....com>,
        "David (ChunMing) Zhou" <David1.Zhou@....com>,
        David Airlie <airlied@...ux.ie>
Cc:     Felix Kuehling <Felix.Kuehling@....com>,
        dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] amdkfd: always select MMU_NOTIFIER

Am 28.03.2018 um 17:53 schrieb Arnd Bergmann:
> Building amdkfd without MMU notifiers is broken:
>
> In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:
> drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' has incomplete type
>
> This adds the missing 'select MMU_NOTIFIER' line to make it build
> cleanly all the time.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Christian König <christian.koenig@....com>, but I would wait 
on what Felix says to that.

> ---
>   drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig
> index ed2f06c9f346..5a26acb90e19 100644
> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig
> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
> @@ -4,6 +4,7 @@
>   
>   config HSA_AMD
>   	tristate "HSA kernel driver for AMD GPU devices"
> +	select MMU_NOTIFIER
>   	depends on DRM_AMDGPU && X86_64
>   	imply AMD_IOMMU_V2
>   	help