linux-kernel - Re: [PATCH] amdkfd: always select MMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADYN=9LTmdLzeszPDeLZ1==9g1ciS1ubunC6jdjLJUiv6J6N3Q@mail.gmail.com>
Date:   Thu, 19 Apr 2018 12:56:26 +0200
From:   Anders Roxell <anders.roxell@...aro.org>
To:     Christian König <christian.koenig@....com>
Cc:     Arnd Bergmann <arnd@...db.de>, Oded Gabbay <oded.gabbay@...il.com>,
        Alex Deucher <alexander.deucher@....com>,
        "David (ChunMing) Zhou" <David1.Zhou@....com>,
        David Airlie <airlied@...ux.ie>,
        Felix Kuehling <Felix.Kuehling@....com>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        amd-gfx@...ts.freedesktop.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] amdkfd: always select MMU_NOTIFIER

On 28 March 2018 at 18:04, Christian König <christian.koenig@....com> wrote:
> Am 28.03.2018 um 17:53 schrieb Arnd Bergmann:
>>
>> Building amdkfd without MMU notifiers is broken:
>>
>> In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:
>> drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier'
>> has incomplete type
>>
>> This adds the missing 'select MMU_NOTIFIER' line to make it build
>> cleanly all the time.
>>
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
>
> Acked-by: Christian König <christian.koenig@....com>, but I would wait on
> what Felix says to that.

Tested-by: Anders Roxell <anders.roxell@...aro.org>

Randy sent the same patch [1] and its still required.

Cheers,
Anders
[1] https://patchwork.kernel.org/patch/10340885/

>
>
>> ---
>>   drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig
>> b/drivers/gpu/drm/amd/amdkfd/Kconfig
>> index ed2f06c9f346..5a26acb90e19 100644
>> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig
>> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
>> @@ -4,6 +4,7 @@
>>     config HSA_AMD
>>         tristate "HSA kernel driver for AMD GPU devices"
>> +       select MMU_NOTIFIER
>>         depends on DRM_AMDGPU && X86_64
>>         imply AMD_IOMMU_V2
>>         help
>
>