linux-kernel - Re: [PATCH] mm: Use octal not symbolic permissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180328190726.GR9275@dhcp22.suse.cz>
Date:   Wed, 28 Mar 2018 21:07:26 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
        Hugh Dickins <hughd@...gle.com>,
        Christoph Lameter <cl@...ux.com>,
        Pekka Enberg <penberg@...nel.org>,
        David Rientjes <rientjes@...gle.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Minchan Kim <minchan@...nel.org>,
        Nitin Gupta <ngupta@...are.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Seth Jennings <sjenning@...hat.com>,
        Dan Streetman <ddstreet@...e.org>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] mm: Use octal not symbolic permissions

On Wed 28-03-18 08:44:51, Joe Perches wrote:
> On Wed, 2018-03-28 at 15:06 +0200, Michal Hocko wrote:
> > On Mon 26-03-18 15:22:32, Joe Perches wrote:
> > > mm/*.c files use symbolic and octal styles for permissions.
> > > 
> > > Using octal and not symbolic permissions is preferred by many as more
> > > readable.
> > > 
> > > https://lkml.org/lkml/2016/8/2/1945
> > > 
> > > Prefer the direct use of octal for permissions.
> > > 
> > > Done using
> > > $ scripts/checkpatch.pl -f --types=SYMBOLIC_PERMS --fix-inplace mm/*.c
[...]
> > I hope I haven't overlooked any potential mismatch...
> 
> Doubtful as the conversion is completely automated.

Ohh, I failed to see --fix-inplace option for checkpatch. I wasn't aware
that checkpatch can perform changes as well.

-- 
Michal Hocko
SUSE Labs