linux-kernel - Re: [PATCH 1/3] virt: vbox: Add vbg_req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2f9fe54-4ae6-df3b-4af4-aeec0b11f0a4@redhat.com>
Date:   Thu, 29 Mar 2018 15:16:49 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Michael Thayer <michael.thayer@...cle.com>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 1/3] virt: vbox: Add vbg_req_free() helper function

Hi,

On 29-03-18 13:56, Greg Kroah-Hartman wrote:
> On Thu, Mar 29, 2018 at 01:21:14PM +0200, Hans de Goede wrote:
>> +void vbg_req_free(void *req, size_t len)
>> +{
>> +	if (!req)
>> +		return;
>> +
>> +	kfree(req);
>> +}
> 
> Wait, no, this isn't ok.  Don't create wrapper functions that you never
> use except as a wrapper :(
> 
> I can see someone sending me almost the indental revert patch right
> after this one gets applied...

The 2nd patch in the series changes this function to be more then
just a wrapper around kfree. As mentioned in the commit message
this is a preparation patch for that 2nd patch, the idea is that
by splitting out the patch replacing all the kfree() calls with
vbg_req_free() calls the 2nd patch becomes easier to review.

Regards,

Hans