linux-kernel - Re: [PATCH] time: export nsec_to_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1522335490.2964.2.camel@intel.com>
Date:   Thu, 29 Mar 2018 22:58:10 +0800
From:   Zhang Rui <rui.zhang@...el.com>
To:     Arnd Bergmann <arnd@...db.de>,
        John Stultz <john.stultz@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>
Cc:     Viresh Kumar <viresh.kumar@...aro.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        Al Viro <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] time: export nsec_to_clock_t

On 三, 2018-03-28 at 16:11 +0200, Arnd Bergmann wrote:
> nsec_to_clock_t was traditionally used only in the core kernel, now
> we
> have a sysfs file that needs it from a loadable module, causing a
> link-time error:
> 
> ERROR: "nsec_to_clock_t" [drivers/thermal/thermal_sys.ko] undefined!
> 
> This exports the function the same way that we do for related
> interfaces.
> 
> Fixes: 96cea33badc5 ("thermal: Add cooling device's statistics in
> sysfs")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks for the fix.
can I take this patch through thermal tree?

thanks,
rui
> ---
>  kernel/time/time.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/time/time.c b/kernel/time/time.c
> index 6fa99213fc72..97a262531f68 100644
> --- a/kernel/time/time.c
> +++ b/kernel/time/time.c
> @@ -768,6 +768,7 @@ u64 nsec_to_clock_t(u64 x)
>  	return div_u64(x * 9, (9ull * NSEC_PER_SEC + (USER_HZ / 2))
> / USER_HZ);
>  #endif
>  }
> +EXPORT_SYMBOL(nsec_to_clock_t);
>  
>  u64 jiffies64_to_nsecs(u64 j)
>  {