linux-kernel - Re: [PATCH] time: export nsec_to_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1803292108350.1486@nanos.tec.linutronix.de>
Date:   Thu, 29 Mar 2018 21:11:42 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Zhang Rui <rui.zhang@...el.com>
cc:     Arnd Bergmann <arnd@...db.de>,
        John Stultz <john.stultz@...aro.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        Al Viro <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] time: export nsec_to_clock_t

On Thu, 29 Mar 2018, Zhang Rui wrote:
> On 三, 2018-03-28 at 16:11 +0200, Arnd Bergmann wrote:
> > nsec_to_clock_t was traditionally used only in the core kernel, now
> > we
> > have a sysfs file that needs it from a loadable module, causing a
> > link-time error:
> > 
> > ERROR: "nsec_to_clock_t" [drivers/thermal/thermal_sys.ko] undefined!
> > 
> > This exports the function the same way that we do for related
> > interfaces.
> > 
> > Fixes: 96cea33badc5 ("thermal: Add cooling device's statistics in
> > sysfs")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> Thanks for the fix.
> can I take this patch through thermal tree?

Well, the question is what's the point of that?

Why does a new interface expose time in state in clock_t instead in normal
time units, e.g. nsec/usec/msec ?

That makes no sense whatsoever.

Thanks,

	tglx