linux-kernel - Re: [PATCH] Revert "crypto/ecc: Remove stack VLA usage"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180330163930.GA27856@gondor.apana.org.au>
Date:   Sat, 31 Mar 2018 00:39:31 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Kees Cook <keescook@...omium.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "crypto/ecc: Remove stack VLA usage"

On Mon, Mar 26, 2018 at 04:03:08PM -0700, Kees Cook wrote:
> This reverts commit 14de52112ee70ca289fa77bf2d9cbc79fd2c811f.
> 
> The solution was incomplete and inefficient. This will be fixed
> correctly in the next patch.
> 
> Signed-off-by: Kees Cook <keescook@...omium.org>

Hmm you didn't post this to linux-crypto so it's not in patchwork.

Anyway, I'd prefer if you just squashed this together with the
subsequent patch.  It's not that complex to require a revert and
a new patch to be readable.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt