linux-kernel - Re: [PATCH] Revert "crypto/ecc: Remove stack VLA usage"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKaB169dB47u5YT3ot-r2PvTcT+5Ng+1ZQZV3f3azkJAg@mail.gmail.com>
Date:   Fri, 30 Mar 2018 09:49:41 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Revert "crypto/ecc: Remove stack VLA usage"

On Fri, Mar 30, 2018 at 9:39 AM, Herbert Xu <herbert@...dor.apana.org.au> wrote:
> On Mon, Mar 26, 2018 at 04:03:08PM -0700, Kees Cook wrote:
>> This reverts commit 14de52112ee70ca289fa77bf2d9cbc79fd2c811f.
>>
>> The solution was incomplete and inefficient. This will be fixed
>> correctly in the next patch.
>>
>> Signed-off-by: Kees Cook <keescook@...omium.org>
>
> Hmm you didn't post this to linux-crypto so it's not in patchwork.
>
> Anyway, I'd prefer if you just squashed this together with the
> subsequent patch.  It's not that complex to require a revert and
> a new patch to be readable.

Sounds good, thanks!

-Kees

-- 
Kees Cook
Pixel Security