linux-kernel - Re: [v2] ftrace: drop a VLA in module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 31 Mar 2018 11:55:16 +0200
From:   Salvatore Mesoraca <s.mesoraca16@...il.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kernel@...r.kernel.org,
        Kernel Hardening <kernel-hardening@...ts.openwall.com>,
        Ingo Molnar <mingo@...hat.com>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [v2] ftrace: drop a VLA in module_exists()

2018-03-30 16:34 GMT+02:00 Steven Rostedt <rostedt@...dmis.org>:
> On Fri, 30 Mar 2018 10:53:08 +0200
> Salvatore Mesoraca <s.mesoraca16@...il.com> wrote:
>
> Couple of things. First, "PATCH" was dropped from the subject. If my
> inbox was busy today, I probably would have missed this email.

Aargh, I'm sorry for this, I didn't notice it.

>> Avoid a VLA[1] by using a real constant expression instead of a variable.
>> The compiler should be able to optimize the original code and avoid using
>> an actual VLA. Anyway this change is useful because it will avoid a false
>> positive with -Wvla, it might also help the compiler generating better
>> code.
>>
>> [1] https://lkml.org/lkml/2018/3/7/621
>
> Second, do not use lkml.org, use http://lkml.kernel.org/r/<messageid>
>
> Search for "Link:" tags in git log to see examples.

Thank you for the suggestion.

> Other than that, the patch looks fine to me and I can pull it for the
> next merge window.

Thank you very much,

Salvatore