linux-kernel - Re: [PATCH] autofs4: use wake_up() instead of wake_up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ebdc431d-cea8-378c-aae5-3b7441bb93c0@themaw.net>
Date:   Sun, 1 Apr 2018 09:31:09 +0800
From:   Ian Kent <raven@...maw.net>
To:     Andrei Vagin <avagin@...nvz.org>
Cc:     autofs@...r.kernel.org, linux-kernel@...r.kernel.org,
        Matthew Wilcox <mawilcox@...rosoft.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] autofs4: use wake_up() instead of wake_up_interruptible

On 31/03/18 10:28, Andrei Vagin wrote:
> In "autofs4: use wait_event_killable",  wait_event_interruptible() was
> replaced by wait_event_killable(), but in this case we have to use
> wake_up() instead of wake_up_interruptible().

Why do you believe wake_up() is needed rather than wake_up_interruptible()?

Now that I'm thinking about the wake up I'm wondering if this is in fact
what's needed. Rather, I think maybe wake_up_all() is probably the only
one that will actually do what's needed.

There's an individual wait queue for each mount, there can be multiple
waiters for a mount, they all should be woken up when the daemon signals
mount completion.

> 
> Cc: Matthew Wilcox <mawilcox@...rosoft.com>
> Cc: Ian Kent <raven@...maw.net>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Andrei Vagin <avagin@...nvz.org>
> ---
>  fs/autofs4/waitq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c
> index c160e9b3aa0f..be9c3dc048ab 100644
> --- a/fs/autofs4/waitq.c
> +++ b/fs/autofs4/waitq.c
> @@ -549,7 +549,7 @@ int autofs4_wait_release(struct autofs_sb_info *sbi, autofs_wqt_t wait_queue_tok
>  	kfree(wq->name.name);
>  	wq->name.name = NULL;	/* Do not wait on this queue */
>  	wq->status = status;
> -	wake_up_interruptible(&wq->queue);
> +	wake_up(&wq->queue);
>  	if (!--wq->wait_ctr)
>  		kfree(wq);
>  	mutex_unlock(&sbi->wq_mutex);
>