lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1522597785.2654.54.camel@codethink.co.uk> Date: Sun, 01 Apr 2018 16:49:45 +0100 From: Ben Hutchings <ben.hutchings@...ethink.co.uk> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org Cc: stable@...r.kernel.org, Wei Xu <xuwei5@...ilicon.com>, Guodong Xu <guodong.xu@...aro.org>, Amit Pundir <amit.pundir@...aro.org>, Rob Herring <robh+dt@...nel.org>, John Youn <johnyoun@...opsys.com>, Douglas Anderson <dianders@...omium.org>, Chen Yu <chenyu56@...wei.com>, Felipe Balbi <felipe.balbi@...ux.intel.com>, linux-usb@...r.kernel.org, John Stultz <john.stultz@...aro.org>, Sasha Levin <alexander.levin@...rosoft.com> Subject: Re: [PATCH 4.4 068/134] usb: dwc2: Make sure we disconnect the gadget state On Mon, 2018-03-19 at 19:05 +0100, Greg Kroah-Hartman wrote: > 4.4-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: John Stultz <john.stultz@...aro.org> > > > [ Upstream commit dad3f793f20fbb5c0c342f0f5a0bdf69a4d76089 ] Maybe we should also have: commit d2471d4a24dfbff5e463d382e2c6fec7d7e25a09 Author: John Stultz <john.stultz@...aro.org> Date: Mon Oct 23 14:32:48 2017 -0700 usb: dwc2: Improve gadget state disconnection handling Ben. > I had seen some odd behavior with HiKey's usb-gadget interface > that I finally seemed to have chased down. Basically every other > time I plugged in the OTG port, the gadget interface would > properly initialize. The other times, I'd get a big WARN_ON > in dwc2_hsotg_init_fifo() about the fifo_map not being clear. > > Ends up if we don't disconnect the gadget state, the fifo-map > doesn't get cleared properly, which causes WARN_ON messages and > also results in the device not properly being setup as a gadget > every other time the OTG port is connected. > > So this patch adds a call to dwc2_hsotg_disconnect() in the > reset path so the state is properly cleared. > > With it, the gadget interface initializes properly on every > plug in. > > Cc: Wei Xu <xuwei5@...ilicon.com> > Cc: Guodong Xu <guodong.xu@...aro.org> > Cc: Amit Pundir <amit.pundir@...aro.org> > Cc: Rob Herring <robh+dt@...nel.org> > Cc: John Youn <johnyoun@...opsys.com> > Cc: Douglas Anderson <dianders@...omium.org> > Cc: Chen Yu <chenyu56@...wei.com> > Cc: Felipe Balbi <felipe.balbi@...ux.intel.com> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > Cc: linux-usb@...r.kernel.org > Acked-by: John Youn <johnyoun@...opsys.com> > Signed-off-by: John Stultz <john.stultz@...aro.org> > Signed-off-by: Felipe Balbi <felipe.balbi@...ux.intel.com> > Signed-off-by: Sasha Levin <alexander.levin@...rosoft.com> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > --- > drivers/usb/dwc2/hcd.c | 1 + > 1 file changed, 1 insertion(+) > > --- a/drivers/usb/dwc2/hcd.c > +++ b/drivers/usb/dwc2/hcd.c > @@ -1385,6 +1385,7 @@ static void dwc2_conn_id_status_change(s > dwc2_core_init(hsotg, false, -1); > dwc2_enable_global_interrupts(hsotg); > spin_lock_irqsave(&hsotg->lock, flags); > + dwc2_hsotg_disconnect(hsotg); > dwc2_hsotg_core_init_disconnected(hsotg, false); > spin_unlock_irqrestore(&hsotg->lock, flags); > dwc2_hsotg_core_connect(hsotg); -- Ben Hutchings Software Developer, Codethink Ltd.
Powered by blists - more mailing lists