linux-kernel - Re: [PATCH] nvmet: fix nvmet_execute_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180402142141.GC28945@localhost.localdomain>
Date:   Mon, 2 Apr 2018 08:21:42 -0600
From:   Keith Busch <keith.busch@...el.com>
To:     Rodrigo Rosatti Galvao <rosattig@...ux.vnet.ibm.com>
Cc:     chaitany kulkarni <ckulkarnilinux@...il.com>,
        Sagi Grimberg <sagi@...mberg.me>, linux-kernel@...r.kernel.org,
        linux-nvme@...ts.infradead.org, hch@....de,
        Chaitanya Kulkarni <chaitanya.kulkarni@....com>
Subject: Re: [PATCH] nvmet: fix nvmet_execute_write_zeroes function

On Mon, Apr 02, 2018 at 10:47:10AM -0300, Rodrigo Rosatti Galvao wrote:
> One thing that I just forgot to explain previously, but I think its
> relevant:
> 
> 1. The command is failing with 4k logical block size, but works with 512B
> 
> 2. With the patch, the command is working for both 512B and 4K.

While you're not getting errors with your patch, you're not zeroing out
the requested blocks, so that's a data corruption.

The issue is the +1 is in the wrong place. It needs to be added to the
native format prior to converting it to a 512b sector count. Do you want
to resend with that change?