linux-kernel - Re: [PATCH] nvmet: fix nvmet_execute_write_zeroes function

Open Source and information security mailing list archives

Message-Id: <c50d1e28-47f9-9ca3-23cf-bf425acd8a4b@linux.vnet.ibm.com>
Date:   Mon, 2 Apr 2018 11:50:45 -0300
From:   Rodrigo Rosatti Galvao <rosattig@...ux.vnet.ibm.com>
To:     Keith Busch <keith.busch@...el.com>
Cc:     Sagi Grimberg <sagi@...mberg.me>,
        Chaitanya Kulkarni <chaitanya.kulkarni@....com>,
        linux-kernel@...r.kernel.org, linux-nvme@...ts.infradead.org,
        chaitany kulkarni <ckulkarnilinux@...il.com>, hch@....de
Subject: Re: [PATCH] nvmet: fix nvmet_execute_write_zeroes function

Thanks Keith. The patch you proposed worked fine!!

I just sent a V2 with that change!

On 04/02/2018 11:21 AM, Keith Busch wrote:
> On Mon, Apr 02, 2018 at 10:47:10AM -0300, Rodrigo Rosatti Galvao wrote:
>> One thing that I just forgot to explain previously, but I think its
>> relevant:
>>
>> 1. The command is failing with 4k logical block size, but works with 512B
>>
>> 2. With the patch, the command is working for both 512B and 4K.
> While you're not getting errors with your patch, you're not zeroing out
> the requested blocks, so that's a data corruption.
>
> The issue is the +1 is in the wrong place. It needs to be added to the
> native format prior to converting it to a 512b sector count. Do you want
> to resend with that change?
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
>

-- 
Rodrigo R. Galvão
Intern - Linux Technology Center - IBM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives