lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <fa001440-0dfe-b84a-e5ef-9285043b5ede@ti.com> Date: Mon, 2 Apr 2018 10:53:23 +0530 From: Kishon Vijay Abraham I <kishon@...com> To: Gustavo Pimentel <gustavo.pimentel@...opsys.com>, <bhelgaas@...gle.com>, <lorenzo.pieralisi@....com>, <Joao.Pinto@...opsys.com>, <jingoohan1@...il.com>, <robh+dt@...nel.org>, <mark.rutland@....com> CC: <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org> Subject: Re: [PATCH 1/8] bindings: PCI: designware: Example update Hi, On Wednesday 28 March 2018 05:08 PM, Gustavo Pimentel wrote: > Changes the IP registers size to accommodate the ATU unroll space. > > Replaces "ctrlreg" reg-name by "dbi" to be coherent with similar drivers. > > Replaces the pcie base address example by a real pcie base address in use. > > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@...opsys.com> > --- > Documentation/devicetree/bindings/pci/designware-pcie.txt | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/designware-pcie.txt b/Documentation/devicetree/bindings/pci/designware-pcie.txt > index 1da7ade..6300762 100644 > --- a/Documentation/devicetree/bindings/pci/designware-pcie.txt > +++ b/Documentation/devicetree/bindings/pci/designware-pcie.txt > @@ -1,7 +1,8 @@ > * Synopsys DesignWare PCIe interface > > Required properties: > -- compatible: should contain "snps,dw-pcie" to identify the core. > +- compatible: > + "snps,dw-pcie" for RC mode; I think irrespective of RC mode or EP mode, "snps,dw-pcie" can be used to identify the pcie core? > - reg: Should contain the configuration address space. > - reg-names: Must be "config" for the PCIe configuration space. > (The old way of getting the configuration address space from "ranges" > @@ -41,11 +42,11 @@ EP mode: > > Example configuration: > > - pcie: pcie@...ff000 { > + pcie: pcie@...00000 { > compatible = "snps,dw-pcie"; > - reg = <0xdffff000 0x1000>, /* Controller registers */ > - <0xd0000000 0x2000>; /* PCI config space */ > - reg-names = "ctrlreg", "config"; > + reg = <0xdfc00000 0x302000>, /* IP registers */ which version of synopsys IP is this. I think the ideal thing to do here is to have a separate register space for iATU. Thanks Kishon
Powered by blists - more mailing lists