linux-kernel - Re: [PATCH v5 05/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41dbb135-f392-3450-029f-bab5a8e2f9d8@codeaurora.org>
Date:   Mon, 2 Apr 2018 10:58:30 +0530
From:   Sricharan R <sricharan@...eaurora.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     mark.rutland@....com, robh@...nel.org, devicetree@...r.kernel.org,
        marc.zyngier@....com, catalin.marinas@....com,
        richardcochran@...il.com, will.deacon@....com,
        linux@...linux.org.uk, linux-kernel@...r.kernel.org,
        david.brown@...aro.org, absahu@...eaurora.org, robh+dt@...nel.org,
        linux-arm-msm@...r.kernel.org, andy.gross@...aro.org,
        linux-soc@...r.kernel.org, sboyd@...eaurora.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 05/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.dtsi



On 3/27/2018 10:34 PM, Bjorn Andersson wrote:
> On Fri 23 Mar 03:18 PDT 2018, Sricharan R wrote:
>> +	soc {
>> +		pinctrl@...0000 {
>> +			serial_0_pins: serial0_pinmux {
> 
> Please, no underscores in the node name.

 ok.

> 
>> +				mux {
> 
> Fyi, you can put the pinctrl properties directly into the state node,
> omitting the "mux" level.
> 

 ok, will change.

>> +					pins = "gpio16", "gpio17";
>> +					function = "blsp_uart0";
>> +					bias-disable;
>> +				};
>> +			};
>> +
> 
> Apart from this the patch looks good.
 Thanks.

Regards,
 Sricharan

-- 
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation