linux-kernel - Re: [PATCH v3] scsi: Introduce sdev_printk_ratelimited to throttle frequent printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5AC34562.6030207@huawei.com>
Date:   Tue, 3 Apr 2018 17:12:02 +0800
From:   Jason Yan <yanaijie@...wei.com>
To:     Wen Yang <wen.yang99@....com.cn>, <jejb@...ux.vnet.ibm.com>,
        <martin.petersen@...cle.com>
CC:     <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <Bart.VanAssche@....com>, <pmladek@...e.com>,
        <sergey.senozhatsky.work@...il.com>, <tj@...nel.org>,
        <jiang.biao2@....com.cn>, <zhong.weidong@....com.cn>,
        Tan Hu <tan.hu@....com.cn>
Subject: Re: [PATCH v3] scsi: Introduce sdev_printk_ratelimited to throttle
 frequent printk


On 2018/4/3 14:04, Wen Yang wrote:
> There would be so many same lines printed by frequent printk if one
> disk went wrong, like,
> [  546.185242] sd 0:1:0:0: rejecting I/O to offline device
> [  546.185258] sd 0:1:0:0: rejecting I/O to offline device
> [  546.185280] sd 0:1:0:0: rejecting I/O to offline device
> [  546.185307] sd 0:1:0:0: rejecting I/O to offline device
> [  546.185334] sd 0:1:0:0: rejecting I/O to offline device
> [  546.185364] sd 0:1:0:0: rejecting I/O to offline device
> [  546.185390] sd 0:1:0:0: rejecting I/O to offline device
> [  546.185410] sd 0:1:0:0: rejecting I/O to offline device
> For slow serial console, the frequent printk may be blocked for a
> long time, and if any spin_lock has been acquired before the printk
> like in scsi_request_fn, watchdog could be triggered.
>
> Related disscussion can be found here,
> https://bugzilla.kernel.org/show_bug.cgi?id=199003
> And Petr brought the idea to throttle the frequent printk, it's
> useless to print the same lines frequently after all.
>
> v2: fix some typos
> v3: limit the print only for the same device
>
> Suggested-by: Petr Mladek<pmladek@...e.com>
> Suggested-by: Sergey Senozhatsky<sergey.senozhatsky.work@...il.com>
> Signed-off-by: Wen Yang<wen.yang99@....com.cn>
> Signed-off-by: Jiang Biao<jiang.biao2@....com.cn>
> Signed-off-by: Tan Hu<tan.hu@....com.cn>
> Reviewed-by: Bart Van Assche<bart.vanassche@....com>
> CC: BartVanAssche<Bart.VanAssche@....com>
> CC: Petr Mladek<pmladek@...e.com>
> CC: Sergey Senozhatsky<sergey.senozhatsky.work@...il.com>
> CC: Martin K. Petersen<martin.petersen@...cle.com>
> CC: "James E.J. Bottomley"<jejb@...ux.vnet.ibm.com>
> CC: Tejun Heo<tj@...nel.org>
> CC: JasonYan<yanaijie@...wei.com>

In my machine it works fine.

Tested-by: Jason Yan <yanaijie@...wei.com>