linux-kernel - Re: [PATCH v3] scsi: Introduce sdev_printk_ratelimited to throttle frequent printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20180406075057.6sywixeqwfpeatbm@pathway.suse.cz>
Date:   Fri, 6 Apr 2018 09:50:57 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     Wen Yang <wen.yang99@....com.cn>
Cc:     jejb@...ux.vnet.ibm.com, martin.petersen@...cle.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Bart.VanAssche@....com, sergey.senozhatsky.work@...il.com,
        tj@...nel.org, jiang.biao2@....com.cn, zhong.weidong@....com.cn,
        Tan Hu <tan.hu@....com.cn>, JasonYan <yanaijie@...wei.com>
Subject: Re: [PATCH v3] scsi: Introduce sdev_printk_ratelimited to throttle
 frequent printk

On Tue 2018-04-03 14:04:40, Wen Yang wrote:
> There would be so many same lines printed by frequent printk if one
> disk went wrong, like,
> [  546.185242] sd 0:1:0:0: rejecting I/O to offline device
> [  546.185258] sd 0:1:0:0: rejecting I/O to offline device
> [  546.185280] sd 0:1:0:0: rejecting I/O to offline device
> [  546.185307] sd 0:1:0:0: rejecting I/O to offline device
> [  546.185334] sd 0:1:0:0: rejecting I/O to offline device
> [  546.185364] sd 0:1:0:0: rejecting I/O to offline device
> [  546.185390] sd 0:1:0:0: rejecting I/O to offline device
> [  546.185410] sd 0:1:0:0: rejecting I/O to offline device
> For slow serial console, the frequent printk may be blocked for a
> long time, and if any spin_lock has been acquired before the printk
> like in scsi_request_fn, watchdog could be triggered.
> 
> Related disscussion can be found here,
> https://bugzilla.kernel.org/show_bug.cgi?id=199003
> And Petr brought the idea to throttle the frequent printk, it's
> useless to print the same lines frequently after all.
> 
> v2: fix some typos
> v3: limit the print only for the same device
> 
> Suggested-by: Petr Mladek <pmladek@...e.com>
> Suggested-by: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
> Signed-off-by: Wen Yang <wen.yang99@....com.cn>
> Signed-off-by: Jiang Biao <jiang.biao2@....com.cn>
> Signed-off-by: Tan Hu <tan.hu@....com.cn>
> Reviewed-by: Bart Van Assche <bart.vanassche@....com>
> CC: BartVanAssche <Bart.VanAssche@....com>
> CC: Petr Mladek <pmladek@...e.com>
> CC: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
> CC: Martin K. Petersen <martin.petersen@...cle.com>
> CC: "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>
> CC: Tejun Heo <tj@...nel.org>
> CC: JasonYan <yanaijie@...wei.com>
> ---
>  drivers/scsi/scsi_lib.c    | 6 +++---
>  drivers/scsi/scsi_scan.c   | 3 +++
>  include/scsi/scsi_device.h | 8 ++++++++
>  3 files changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index c84f931..f77e801 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -1301,7 +1301,7 @@ static int scsi_setup_cmnd(struct scsi_device *sdev, struct request *req)
>  			 * commands.  The device must be brought online
>  			 * before trying any recovery commands.
>  			 */
> -			sdev_printk(KERN_ERR, sdev,
> +			sdev_printk_ratelimited(KERN_ERR, sdev,
>  				    "rejecting I/O to offline device\n");
>  			ret = BLKPREP_KILL;
>  			break;
> @@ -1310,7 +1310,7 @@ static int scsi_setup_cmnd(struct scsi_device *sdev, struct request *req)
>  			 * If the device is fully deleted, we refuse to
>  			 * process any commands as well.
>  			 */
> -			sdev_printk(KERN_ERR, sdev,
> +			sdev_printk_ratelimited(KERN_ERR, sdev,
>  				    "rejecting I/O to dead device\n");
>  			ret = BLKPREP_KILL;
>  			break;
> @@ -1802,7 +1802,7 @@ static void scsi_request_fn(struct request_queue *q)
>  			break;
>  
>  		if (unlikely(!scsi_device_online(sdev))) {
> -			sdev_printk(KERN_ERR, sdev,
> +			sdev_printk_ratelimited(KERN_ERR, sdev,
>  				    "rejecting I/O to offline device\n");
>  			scsi_kill_request(req, q);
>  			continue;
> diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
> index 0880d97..a6da935 100644
> --- a/drivers/scsi/scsi_scan.c
> +++ b/drivers/scsi/scsi_scan.c
> @@ -288,6 +288,9 @@ static struct scsi_device *scsi_alloc_sdev(struct scsi_target *starget,
>  	scsi_change_queue_depth(sdev, sdev->host->cmd_per_lun ?
>  					sdev->host->cmd_per_lun : 1);
>  
> +	/* Enable message ratelimiting. Default is 10 messages per 5 secs. */
> +	ratelimit_state_init(&sdev->sdev_ratelimit_state,
> +			DEFAULT_RATELIMIT_INTERVAL, DEFAULT_RATELIMIT_BURST);

This makes the ratelimiting device independent but it adds another
problem. Several unrelated messages share the ratelimit data now.
It means that cycling on one message might cause that people will
not see the others.

One question is if we really need to ratelimit all three messages.

Another question if we are really printing all the messages in
a single cycle without releasing the spin lock. Then I wonder what
event will cause that the cycle finishes. If the event is independent
then ratelimiting the messages need not help to avoid the softlockup.
I mean that we might cycle faster without the printk but it does
not mean the event would unblock the cycle faster.

Best Regards,
Petr

>  	scsi_sysfs_device_initialize(sdev);
>  
>  	if (shost->hostt->slave_alloc) {
> diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
> index 7ae177c..f1db7f3 100644
> --- a/include/scsi/scsi_device.h
> +++ b/include/scsi/scsi_device.h
> @@ -215,6 +215,8 @@ struct scsi_device {
>  	struct device		sdev_gendev,
>  				sdev_dev;
>  
> +	struct ratelimit_state sdev_ratelimit_state; /* Ratelimit sdev messages. */
> +
>  	struct execute_work	ew; /* used to get process context on put */
>  	struct work_struct	requeue_work;
>  
> @@ -249,6 +251,12 @@ struct scsi_device {
>  #define sdev_printk(l, sdev, fmt, a...)				\
>  	sdev_prefix_printk(l, sdev, NULL, fmt, ##a)
>  
> +#define sdev_printk_ratelimited(l, sdev, fmt, a...)			\
> +({									\
> +	if (sdev && __ratelimit(&sdev->sdev_ratelimit_state))		\
> +		sdev_prefix_printk(l, sdev, NULL, fmt, ##a);		\
> +})
> +
>  __printf(3, 4) void
>  scmd_printk(const char *, const struct scsi_cmnd *, const char *, ...);
>  
> -- 
> 1.8.3.1
>