linux-kernel - Re: [PATCH v6 3/9] pinctrl: actions: Add Actions S900 pinctrl driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180403171401.etcvqe4xrkcl7sbh@linaro.org>
Date:   Tue, 3 Apr 2018 22:44:01 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     Andreas Färber <afaerber@...e.de>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        刘炜 <liuwei@...ions-semi.com>,
        mp-cs@...ions-semi.com, 96boards@...obotics.com,
        devicetree <devicetree@...r.kernel.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        amit.kucheria@...aro.org,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        hzhang@...obotics.com, bdong@...obotics.com,
        Mani Sadhasivam <manivannanece23@...il.com>
Subject: Re: [PATCH v6 3/9] pinctrl: actions: Add Actions S900 pinctrl driver

On Tue, Apr 03, 2018 at 07:03:46PM +0200, Andreas Färber wrote:
> Hi Mani,
> 
> Am 03.04.2018 um 19:00 schrieb Manivannan Sadhasivam:
> > On Sat, Mar 31, 2018 at 12:16:49AM +0300, Andy Shevchenko wrote:
> >> On Wed, Mar 28, 2018 at 8:46 PM, Manivannan Sadhasivam
> >> <manivannan.sadhasivam@...aro.org> wrote:
> >>> +static const struct pinconf_ops owl_pinconf_ops = {
> >>> +       .is_generic = true,
> >>> +       .pin_config_get = owl_pin_config_get,
> >>> +       .pin_config_set = owl_pin_config_set,
> >>> +       .pin_config_group_get = owl_group_config_get,
> >>> +       .pin_config_group_set = owl_group_config_set
> >>
> >> It's still good idea to leave comma here...
> >>
> > 
> > I'm confused. What is the criteria for removing/keeping comma for last member
> > of struct? I followed your gpio driver suggestion.
> 
> No comma for list terminator ("{}") because nothing goes after it; comma
> whenever it allows adding a new line without touching the old one, i.e.
> keeping future diff small.
>

Thanks for the clarification Andreas! Keeping the future diff small is the
key, understood.

Thanks,
Mani
 
> Cheers,
> Andreas
> 
> -- 
> SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)