linux-kernel - Re: [PATCH 4/5] MIPS: perf: Allocate per-core counters on demand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201804040450.9hvGboKw%fengguang.wu@intel.com>
Date:   Wed, 4 Apr 2018 04:34:38 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Matt Redfearn <matt.redfearn@...s.com>
Cc:     kbuild-all@...org, James Hogan <jhogan@...nel.org>,
        Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...ux-mips.org,
        Matt Redfearn <matt.redfearn@...s.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>
Subject: Re: [PATCH 4/5] MIPS: perf: Allocate per-core counters on demand

Hi Matt,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/perf/core]
[also build test ERROR on v4.16 next-20180403]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Matt-Redfearn/MIPS-perf-MT-fixes-and-improvements/20180404-011026
config: mips-gpr_defconfig (attached as .config)
compiler: mipsel-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=mips 

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/kernel.h:14:0,
                    from include/linux/cpumask.h:10,
                    from arch/mips/kernel/perf_event_mipsxx.c:18:
   arch/mips/kernel/perf_event_mipsxx.c: In function 'mipsxx_pmu_free_counter':
>> arch/mips/kernel/perf_event_mipsxx.c:365:42: error: 'cpu' undeclared (first use in this function)
     pr_debug("CPU%d released counter %d\n", cpu, hwc->idx);
                                             ^
   include/linux/printk.h:136:17: note: in definition of macro 'no_printk'
      printk(fmt, ##__VA_ARGS__);  \
                    ^~~~~~~~~~~
>> arch/mips/kernel/perf_event_mipsxx.c:365:2: note: in expansion of macro 'pr_debug'
     pr_debug("CPU%d released counter %d\n", cpu, hwc->idx);
     ^~~~~~~~
   arch/mips/kernel/perf_event_mipsxx.c:365:42: note: each undeclared identifier is reported only once for each function it appears in
     pr_debug("CPU%d released counter %d\n", cpu, hwc->idx);
                                             ^
   include/linux/printk.h:136:17: note: in definition of macro 'no_printk'
      printk(fmt, ##__VA_ARGS__);  \
                    ^~~~~~~~~~~
>> arch/mips/kernel/perf_event_mipsxx.c:365:2: note: in expansion of macro 'pr_debug'
     pr_debug("CPU%d released counter %d\n", cpu, hwc->idx);
     ^~~~~~~~
   arch/mips/kernel/perf_event_mipsxx.c: In function 'mipsxx_pmu_enable_event':
   arch/mips/kernel/perf_event_mipsxx.c:386:22: error: expected expression before ')' token
     } else if (range > V) {
                         ^
   arch/mips/kernel/perf_event_mipsxx.c: In function 'mipspmu_perf_event_encode':
   arch/mips/kernel/perf_event_mipsxx.c:718:28: error: 'const struct mips_perf_event' has no member named 'range'
      return ((unsigned int)pev->range << 24) |
                               ^~

vim +/cpu +365 arch/mips/kernel/perf_event_mipsxx.c

   339	
   340	static void mipsxx_pmu_free_counter(struct cpu_hw_events *cpuc,
   341					    struct hw_perf_event *hwc)
   342	{
   343	#ifdef CONFIG_MIPS_PERF_SHARED_TC_COUNTERS
   344		int sibling_cpu, cpu = smp_processor_id();
   345	
   346		/* When counters are per-core, free them in all sibling CPUs */
   347		if (!cpu_has_mipsmt_pertccounters) {
   348			struct cpu_hw_events *sibling_cpuc;
   349			unsigned long flags;
   350	
   351			spin_lock_irqsave(&core_counters_lock, flags);
   352	
   353			for_each_cpu(sibling_cpu, &cpu_sibling_map[cpu]) {
   354				sibling_cpuc = per_cpu_ptr(&cpu_hw_events, sibling_cpu);
   355	
   356				clear_bit(hwc->idx, sibling_cpuc->used_mask);
   357				pr_debug("CPU%d released core counter %d\n",
   358					 sibling_cpu, hwc->idx);
   359			}
   360	
   361			spin_unlock_irqrestore(&core_counters_lock, flags);
   362			return;
   363		}
   364	#endif
 > 365		pr_debug("CPU%d released counter %d\n", cpu, hwc->idx);
   366		clear_bit(hwc->idx, cpuc->used_mask);
   367	}
   368	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (19550 bytes)