linux-kernel - Re: [PATCH v2] dp83640: Ensure against premature access to PHY registers after reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180406172337.GR17495@lunn.ch>
Date:   Fri, 6 Apr 2018 19:23:37 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Esben Haabendal <esben.haabendal@...il.com>
Cc:     netdev@...r.kernel.org, richardcochran@...il.com,
        f.fainelli@...il.com, linux-kernel@...r.kernel.org,
        Esben Haabendal <eha@...f.com>
Subject: Re: [PATCH v2] dp83640: Ensure against premature access to PHY
 registers after reset

On Fri, Apr 06, 2018 at 07:08:44PM +0200, Esben Haabendal wrote:
> From: Esben Haabendal <eha@...f.com>

Hi Esben

It it good to have some form of commit message. Something like:

The datasheet specifies a 3uS pause after performing a software
reset. The default implementation of genphy_soft_reset() does not
provide this, so implement soft_reset with the needed pause.

With that, or something similar added:

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew