linux-kernel - [PATCH 2/3] mm: Replace S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180407184726.8634-2-paulmcquad@gmail.com>
Date:   Sat,  7 Apr 2018 19:47:25 +0100
From:   Paul McQuade <paulmcquad@...il.com>
To:     paulmcquad@...il.com
Cc:     konrad.wilk@...cle.com, labbott@...hat.com,
        gregkh@...uxfoundation.org, akpm@...ux-foundation.org,
        guptap@...eaurora.org, vbabka@...e.cz, mgorman@...hsingularity.net,
        hannes@...xchg.org, rientjes@...gle.com, mhocko@...e.com,
        rppt@...ux.vnet.ibm.com, dave@...olabs.net, hmclauchlan@...com,
        tglx@...utronix.de, pombredanne@...b.com,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: [PATCH 2/3] mm: Replace S_IWUSR with 0200

Fix checkpatch warnings about S_IWUSR being less readable than
providing the permissions octal as '0200'.

Signed-off-by: Paul McQuade <paulmcquad@...il.com>
---
 mm/cma_debug.c  | 4 ++--
 mm/compaction.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/cma_debug.c b/mm/cma_debug.c
index 6494c7a7d257..f0af3f93d1e4 100644
--- a/mm/cma_debug.c
+++ b/mm/cma_debug.c
@@ -172,10 +172,10 @@ static void cma_debugfs_add_one(struct cma *cma, int idx)
 
 	tmp = debugfs_create_dir(name, cma_debugfs_root);
 
-	debugfs_create_file("alloc", S_IWUSR, tmp, cma,
+	debugfs_create_file("alloc", 0200, tmp, cma,
 				&cma_alloc_fops);
 
-	debugfs_create_file("free", S_IWUSR, tmp, cma,
+	debugfs_create_file("free", 0200, tmp, cma,
 				&cma_free_fops);
 
 	debugfs_create_file("base_pfn", 0444, tmp,
diff --git a/mm/compaction.c b/mm/compaction.c
index 88d01a50a015..50d0000a6afd 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1900,7 +1900,7 @@ static ssize_t sysfs_compact_node(struct device *dev,
 
 	return count;
 }
-static DEVICE_ATTR(compact, S_IWUSR, NULL, sysfs_compact_node);
+static DEVICE_ATTR(compact, 0200, NULL, sysfs_compact_node);
 
 int compaction_register_node(struct node *node)
 {
-- 
2.16.2