linux-kernel - [PATCH 3/3] mm: replace S_IRUSR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat,  7 Apr 2018 19:47:26 +0100
From:   Paul McQuade <paulmcquad@...il.com>
To:     paulmcquad@...il.com
Cc:     konrad.wilk@...cle.com, labbott@...hat.com,
        gregkh@...uxfoundation.org, akpm@...ux-foundation.org,
        guptap@...eaurora.org, vbabka@...e.cz, mgorman@...hsingularity.net,
        hannes@...xchg.org, rientjes@...gle.com, mhocko@...e.com,
        rppt@...ux.vnet.ibm.com, dave@...olabs.net, hmclauchlan@...com,
        tglx@...utronix.de, pombredanne@...b.com,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: [PATCH 3/3] mm: replace S_IRUSR | S_IWUSR with 0600

Fix checkpatch warnings about S_IRUSR | S_IWUSR being less readable than
providing the permissions octal as '0600'.

Signed-off-by: Paul McQuade <paulmcquad@...il.com>
---
 mm/failslab.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/failslab.c b/mm/failslab.c
index 1f2f248e3601..b135ebb88b6f 100644
--- a/mm/failslab.c
+++ b/mm/failslab.c
@@ -42,7 +42,7 @@ __setup("failslab=", setup_failslab);
 static int __init failslab_debugfs_init(void)
 {
 	struct dentry *dir;
-	umode_t mode = S_IFREG | S_IRUSR | S_IWUSR;
+	umode_t mode = S_IFREG | 0600;
 
 	dir = fault_create_debugfs_attr("failslab", NULL, &failslab.attr);
 	if (IS_ERR(dir))
-- 
2.16.2