linux-kernel - Re: [PATCH v2 7/9] PCI: dwc: Replace lower into upper case characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0dad6b43476c1a70944e3e7c245040243ddc2a04.camel@perches.com>
Date:   Mon, 09 Apr 2018 03:25:46 -0700
From:   Joe Perches <joe@...ches.com>
To:     Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        bhelgaas@...gle.com, lorenzo.pieralisi@....com,
        Joao.Pinto@...opsys.com, jingoohan1@...il.com, kishon@...com,
        robh+dt@...nel.org, mark.rutland@....com
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 7/9] PCI: dwc: Replace lower into upper case
 characters

On Mon, 2018-04-09 at 10:41 +0100, Gustavo Pimentel wrote:
> Replaces lower into upper case characters in comments and debug printks.
> 
> This is an attempt to keep the messages coherent within the designware
> driver.

It'd be nice to make all the dwc drivers use the same
message wording.

For instance:

drivers/pci/dwc/pci-keystone.c: dev_err(dev, "phy link never came up\n");
drivers/pci/dwc/pcie-designware.c:      dev_err(pci->dev, "phy link never came up\n");
drivers/pci/host/pcie-xilinx-nwl.c:     dev_err(dev, "PHY link never came up\n");