linux-kernel - Re: [PATCH v2 7/9] PCI: dwc: Replace lower into upper case characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7aa4990-92ad-3e5e-de27-40df4f29f08b@synopsys.com>
Date:   Mon, 9 Apr 2018 14:10:44 +0100
From:   Gustavo Pimentel <gustavo.pimentel@...opsys.com>
To:     Joe Perches <joe@...ches.com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "Joao.Pinto@...opsys.com" <Joao.Pinto@...opsys.com>,
        "jingoohan1@...il.com" <jingoohan1@...il.com>,
        "kishon@...com" <kishon@...com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>
Cc:     "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 7/9] PCI: dwc: Replace lower into upper case characters

Hi Joe,

On 09/04/2018 11:25, Joe Perches wrote:
> On Mon, 2018-04-09 at 10:41 +0100, Gustavo Pimentel wrote:
>> Replaces lower into upper case characters in comments and debug printks.
>>
>> This is an attempt to keep the messages coherent within the designware
>> driver.
> 
> It'd be nice to make all the dwc drivers use the same
> message wording.
> 
> For instance:
> 
> drivers/pci/dwc/pci-keystone.c: dev_err(dev, "phy link never came up\n");
> drivers/pci/dwc/pcie-designware.c:      dev_err(pci->dev, "phy link never came up\n");
> drivers/pci/host/pcie-xilinx-nwl.c:     dev_err(dev, "PHY link never came up\n");

I also agree, I added a task to my backlog to fix that. However, this task
shouldn't be done in this patch series since it's a more broader task involving
many drivers and different maintainers. Agree?

> 

Regards,
Gustavo