linux-kernel - Re: [PATCH] X86/VMX: Disable VMX preempition timer if MWAIT is not intercepted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2cd149f0-6ebe-59fc-addb-8b4b05e07d80@redhat.com>
Date:   Tue, 10 Apr 2018 11:04:13 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     KarimAllah Ahmed <karahmed@...zon.de>,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Cc:     Radim Krčmář <rkrcmar@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org
Subject: Re: [PATCH] X86/VMX: Disable VMX preempition timer if MWAIT is not
 intercepted

On 10/04/2018 10:50, KarimAllah Ahmed wrote:
>  	WARN_ON(preemptible());
> -	if (!kvm_x86_ops->set_hv_timer)
> +	if (!kvm_x86_ops->has_hv_timer ||
> +	    !kvm_x86_ops->has_hv_timer(apic->vcpu))
>  		return false;
>  
>  	if (!apic_lvtt_period(apic) && atomic_read(&ktimer->pending))

Why not just return -ENOTSUP from vmx_set_hv_timer?

Thanks,

Paolo