Message-ID: <D0158A423229094DA7ABF71CF2FA0DA34E9226AF@SHSMSX104.ccr.corp.intel.com>
Date:   Tue, 10 Apr 2018 14:23:52 +0000
From:   "Liang, Cunming" <cunming.liang@...el.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>
CC:     Paolo Bonzini <pbonzini@...hat.com>,
        "Bie, Tiwei" <tiwei.bie@...el.com>,
        Jason Wang <jasowang@...hat.com>,
        "alex.williamson@...hat.com" <alex.williamson@...hat.com>,
        "ddutile@...hat.com" <ddutile@...hat.com>,
        "Duyck, Alexander H" <alexander.h.duyck@...el.com>,
        "virtio-dev@...ts.oasis-open.org" <virtio-dev@...ts.oasis-open.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Daly, Dan" <dan.daly@...el.com>,
        "Wang, Zhihong" <zhihong.wang@...el.com>,
        "Tan, Jianfeng" <jianfeng.tan@...el.com>,
        "Wang, Xiao W" <xiao.w.wang@...el.com>
Subject: RE: [virtio-dev] Re: [RFC] vhost: introduce mdev based hardware
 vhost backend



> -----Original Message-----
> From: Michael S. Tsirkin [mailto:mst@...hat.com]
> Sent: Tuesday, April 10, 2018 9:36 PM
> To: Liang, Cunming <cunming.liang@...el.com>
> Cc: Paolo Bonzini <pbonzini@...hat.com>; Bie, Tiwei <tiwei.bie@...el.com>;
> Jason Wang <jasowang@...hat.com>; alex.williamson@...hat.com;
> ddutile@...hat.com; Duyck, Alexander H <alexander.h.duyck@...el.com>;
> virtio-dev@...ts.oasis-open.org; linux-kernel@...r.kernel.org;
> kvm@...r.kernel.org; virtualization@...ts.linux-foundation.org;
> netdev@...r.kernel.org; Daly, Dan <dan.daly@...el.com>; Wang, Zhihong
> <zhihong.wang@...el.com>; Tan, Jianfeng <jianfeng.tan@...el.com>; Wang, Xiao
> W <xiao.w.wang@...el.com>
> Subject: Re: [virtio-dev] Re: [RFC] vhost: introduce mdev based hardware vhost
> backend
> 
> On Tue, Apr 10, 2018 at 09:23:53AM +0000, Liang, Cunming wrote:
> >
> >
> > > -----Original Message-----
> > > From: Paolo Bonzini [mailto:pbonzini@...hat.com]
> > > Sent: Tuesday, April 10, 2018 3:52 PM
> > > To: Bie, Tiwei <tiwei.bie@...el.com>; Jason Wang
> > > <jasowang@...hat.com>
> > > Cc: mst@...hat.com; alex.williamson@...hat.com; ddutile@...hat.com;
> > > Duyck, Alexander H <alexander.h.duyck@...el.com>;
> > > virtio-dev@...ts.oasis- open.org; linux-kernel@...r.kernel.org;
> > > kvm@...r.kernel.org; virtualization@...ts.linux-foundation.org;
> > > netdev@...r.kernel.org; Daly, Dan <dan.daly@...el.com>; Liang,
> > > Cunming <cunming.liang@...el.com>; Wang, Zhihong
> > > <zhihong.wang@...el.com>; Tan, Jianfeng <jianfeng.tan@...el.com>;
> > > Wang, Xiao W <xiao.w.wang@...el.com>
> > > Subject: Re: [virtio-dev] Re: [RFC] vhost: introduce mdev based
> > > hardware vhost backend
> > >
> > > On 10/04/2018 06:57, Tiwei Bie wrote:
> > > >> So you just move the abstraction layer from qemu to kernel, and
> > > >> you still need different drivers in kernel for different device
> > > >> interfaces of accelerators. This looks even more complex than
> > > >> leaving it in qemu. As you said, another idea is to implement
> > > >> userspace vhost backend for accelerators which seems easier and
> > > >> could co-work with other parts of qemu without inventing new type of
> messages.
> > > >
> > > > I'm not quite sure. Do you think it's acceptable to add various
> > > > vendor specific hardware drivers in QEMU?
> > >
> > > I think so.  We have vendor-specific quirks, and at some point there
> > > was an idea of using quirks to implement (vendor-specific) live
> > > migration support for assigned devices.
> >
> > Vendor-specific quirks of accessing VGA is a small portion. Other major portions
> are still handled by guest driver.
> >
> > While in this case, when saying various vendor specific drivers in QEMU, it says
> QEMU takes over and provides the entire user space device drivers. Some parts
> are even not relevant to vhost, they're basic device function enabling. Moreover,
> it could be different kinds of devices(network/block/...) under vhost. No matter
> # of vendors or # of types, total LOC is not small.
> >
> > The idea is to avoid introducing these extra complexity out of QEMU, keeping
> vhost adapter simple. As vhost protocol is de factor standard, it leverages kernel
> device driver to provide the diversity. Changing once in QEMU, then it supports
> multi-vendor devices whose drivers naturally providing kernel driver there.
> >
> > If QEMU is going to build a user space driver framework there, we're open mind
> on that, even leveraging DPDK as the underlay library. Looking forward to more
> others' comments from community.
> >
> > Steve
> 
> Dependency on a kernel driver is fine IMHO. It's the dependency on a DPDK
> backend that makes people unhappy, since the functionality in question is setup-
> time only.

Agreed, we don't see dependency on kernel driver is a problem.

mdev based vhost backend (this patch set) is independent with vhost-user extension patch set. In fact, there're a few vhost-user providers, DPDK librte_vhost is one of them. FD.IO/VPP and snabbswitch have their own vhost-user providers. So I can't agree on vhost-user extension patch depends on DPDK backend. But anyway, that's the topic of another mail thread.

> 
> As others said, we do not need to go overeboard. A couple of small vendor-
> specific quirks in qemu isn't a big deal.

It's quite challenge to identify it's small or not, there's no uniform metric.

It's only dependent on QEMU itself, that's the obvious benefit. Tradeoff is to build the entire device driver. We don't object to do that in QEMU, but wanna make sure to understand the boundary size clearly.

> 
> > >
> > > Paolo

Powered by blists - more mailing lists