linux-kernel - Re: [PATCH v8 2/3] mtd: spi-nor: add rockchip serial flash controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAEAJfCYm4Z20x8PdU3uHh_0BExTCAoOy5Aq=ZXWLJKaB1C9kQ@mail.gmail.com>
Date:   Tue, 10 Apr 2018 15:34:57 -0300
From:   Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
To:     Andy Yan <andy.yan@...k-chips.com>
Cc:     Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        linux-mtd@...ts.infradead.org, shawn.lin@...k-chips.com,
        Heiko Stuebner <heiko@...ech.de>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>
Subject: Re: [PATCH v8 2/3] mtd: spi-nor: add rockchip serial flash controller driver

Hi Andy,

Just a very minor nit.

On 8 February 2018 at 09:18, Andy Yan <andy.yan@...k-chips.com> wrote:
[..]
> +
> +static int get_if_type(struct rockchip_sfc *sfc, enum spi_nor_protocol proto)
> +{

I understand that this got copy-pasted from some other driver,
but please change this function name to something like
rockchip_sfc_get_if_type().

Thanks,
Eze