linux-kernel - Re: [PATCH] sparc: compat: allow including asm/compat.h for 32-bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a3em5b2Qp_y0uHz95=JbyB7dHuPnfRNWNZ79beV6hGMyQ@mail.gmail.com>
Date:   Wed, 11 Apr 2018 22:25:03 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        sparclinux <sparclinux@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sparc: compat: allow including asm/compat.h for 32-bit

On Wed, Apr 11, 2018 at 9:32 PM, Eric W. Biederman
<ebiederm@...ssion.com> wrote:
> Arnd Bergmann <arnd@...db.de> writes:
>
>> We have several files on sparc that include linux/compat.h and expect
>> asm/compat.h not to be included, otherwise we get a build failure.
>
> Should this say: "We have several files on sparc that include
> linux/compat.h and expect asm/compat.h not be included when
> !CONFIG_COMPAT." ?

Correct, I'll fix it up. I'll say '32-bit builds' instead, which is what
I'm interested in. On sparc64, CONFIG_COMPAT is enabled
unconditionally, so it's really the same thing.

> I don't have your tree and I see asm/compat.h included from
> linux/compat.h already so the description above seems wrong.

I removed the tree from linux-next before the merge window because
of this build regression, if you are interested in the other changes,
please see

git://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git y2038-next

      Arnd