linux-kernel - Re: [PATCH 08/14] ARM: OMAP2: Add functions to save and restore pinctrl context.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180412141639.GV5700@atomide.com>
Date:   Thu, 12 Apr 2018 07:16:39 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Keerthy <j-keerthy@...com>
Cc:     linus.walleij@...aro.org, grygorii.strashko@...com,
        t-kristo@...com, Russ.Dill@...com, linux-omap@...r.kernel.org,
        linux-kernel@...r.kernel.org, ssantosh@...nel.org,
        haojian.zhuang@...aro.org, linux-arm-kernel@...ts.infradead.org,
        d-gerlach@...com, Russ Dill <Russ.Dill@...il.com>
Subject: Re: [PATCH 08/14] ARM: OMAP2: Add functions to save and restore
 pinctrl context.

Hi,

* Keerthy <j-keerthy@...com> [180412 03:56]:
> From: Russ Dill <Russ.Dill@...il.com>
> 
> This adds a pair of context save/restore functions to save/restore the
> state of a set of pinctrl registers. This simplifies some of the AM33XX
> PM code as some of the pinctrl registers are lost when the per power
> domain loses power. The pincrtl code can perform the necessary
> save/restore.

So where's the patch adding callers to this code?

If this cannot be done from regular driver suspend/resume calls,
this probably should be done from cpu_pm notifiers CPU_PM_ENTER and
CPU_PM_EXIT. We should also do the same for GPIO BTW.

BTW, the subject line is wrong here, it should be "pinctrl" :)

Regards,

Tony