[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180416091257.swbt7i6zjfbwysg2@dell>
Date: Mon, 16 Apr 2018 10:12:57 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Simon Horman <horms@...ge.net.au>
Cc: Wolfram Sang <wsa+renesas@...g-engineering.com>,
linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
Thierry Reding <thierry.reding@...il.com>,
Daniel Thompson <daniel.thompson@...aro.org>,
Jingoo Han <jingoohan1@...il.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
linux-pwm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linux-fbdev@...r.kernel.org
Subject: Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with
gpiod_get_direction
On Wed, 11 Apr 2018, Simon Horman wrote:
> On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wolfram Sang wrote:
> > The documentation was wrong, gpiod_get_direction() returns 0/1 instead
> > of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47
> > ("gpio: correct docs about return value of gpiod_get_direction"). Now,
> > fix this user (until a better, system-wide solution is in place).
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> > Acked-by: Daniel Thompson <daniel.thompson@...aro.org>
>
> Reviewed-by: Simon Horman <horms+renesas@...ge.net.au>
Thanks for the Reviewed-by Simon. I have applied it to the original mail.
Do you know why you mail wasn't sent attached to the original thread?
For some reason I received this mail on it's own i.e. not in reply
to the original.
> > ---
> >
> > Changes since V1:
> > * rebased to top-of-linus-tree
> > * added tag from Daniel, thanks!
> >
> > Through which tree does this need to go?
> >
> > drivers/video/backlight/pwm_bl.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> > index 1c2289ddd555..0fa7d2bd0e48 100644
> > --- a/drivers/video/backlight/pwm_bl.c
> > +++ b/drivers/video/backlight/pwm_bl.c
> > @@ -301,14 +301,14 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> >
> > /*
> > * If the GPIO is not known to be already configured as output, that
> > - * is, if gpiod_get_direction returns either GPIOF_DIR_IN or -EINVAL,
> > - * change the direction to output and set the GPIO as active.
> > + * is, if gpiod_get_direction returns either 1 or -EINVAL, change the
> > + * direction to output and set the GPIO as active.
> > * Do not force the GPIO to active when it was already output as it
> > * could cause backlight flickering or we would enable the backlight too
> > * early. Leave the decision of the initial backlight state for later.
> > */
> > if (pb->enable_gpio &&
> > - gpiod_get_direction(pb->enable_gpio) != GPIOF_DIR_OUT)
> > + gpiod_get_direction(pb->enable_gpio) != 0)
> > gpiod_direction_output(pb->enable_gpio, 1);
> >
> > pb->power_supply = devm_regulator_get(&pdev->dev, "power");
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists