linux-kernel - Re: [PATCH 0/3] Fix an Atmel USBA UDC issue introducted in 4.17-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cbdab54a-d01a-2668-c3bc-b5b334a555e0@microchip.com>
Date:   Tue, 17 Apr 2018 10:24:06 +0200
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Romain Izard <romain.izard.pro@...il.com>,
        Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>
CC:     <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-usb@...r.kernel.org>
Subject: Re: [PATCH 0/3] Fix an Atmel USBA UDC issue introducted in 4.17-rc1

On 16/04/2018 at 11:34, Romain Izard wrote:
> The use of GPIO descriptors takes care of inversion flags declared in
> the device tree. The conversion of the Atmel USBA UDC driver introduced
> in 4.17-rc1 missed it, and as a result the inversion will not work.
> 
> In addition, cleanup the code to remove an include left behind after
> the suppression of the support of platform_data to declare USBA
> controllers.
> 
> These changes have not been tested on any hardware, as I do not have
> a board that needs to use inverted GPIOs.
> 
> Romain Izard (3):
>    usb: gadget: udc: atmel: GPIO inversion is handled by gpiod
>    usb: gadget: udc: atmel: Remove obsolete include
>    usb: gadget: udc: atmel: Fix indenting

To the whole series:
Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

Thank you Romain.
Best regards,
   Nicolas

> 
>   drivers/usb/gadget/udc/atmel_usba_udc.c | 22 ++++++++++------------
>   drivers/usb/gadget/udc/atmel_usba_udc.h |  1 -
>   include/linux/usb/atmel_usba_udc.h      | 24 ------------------------
>   3 files changed, 10 insertions(+), 37 deletions(-)
>   delete mode 100644 include/linux/usb/atmel_usba_udc.h
> 


-- 
Nicolas Ferre