linux-kernel - Re: [PATCH 1/3] usb: gadget: udc: atmel: GPIO inversion is handled by gpiod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wowvhas8.fsf@linux.intel.com>
Date:   Wed, 25 Apr 2018 12:53:43 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     Romain Izard <romain.izard.pro@...il.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-usb@...r.kernel.org,
        Romain Izard <romain.izard.pro@...il.com>
Subject: Re: [PATCH 1/3] usb: gadget: udc: atmel: GPIO inversion is handled by gpiod

Romain Izard <romain.izard.pro@...il.com> writes:

> When converting to GPIO descriptors, gpiod_get_value automatically
> handles the line inversion flags from the device tree.
>
> Do not invert the line twice.
>
> Fixes: 3df034081021fa4b6967ce3364bc7d867ec1c870

your fixes line is incorrect. Please fix and resend. While at that,
please collect Acked-bys and Tested-bys, etc.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)