linux-kernel - Re: [PATCH] trace: add missing forward declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Apr 2018 02:18:47 +0000
From:   Ahbong Chang <cwahbong@...gle.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Todd Poynor <toddpoynor@...gle.com>,
        Philippe Ombredanne <pombredanne@...b.com>
Subject: Re: [PATCH] trace: add missing forward declaration

It does not fail with any config without this fix. This is for new work.

-- Ahbong

On Mon, Apr 16, 2018 at 9:24 PM Steven Rostedt <rostedt@...dmis.org> wrote:

> On Mon, 16 Apr 2018 10:36:25 +0800
> Ahbong Chang <cwahbong@...gle.com> wrote:

> > Without this forward declaration compile may fail if this header is
> > included only for registering other probe event without struct
> > pool_workqueue.
> >

> Is this for new work or is there a config which this fails with today?

> -- Steve

> > Signed-off-by: Ahbong Chang <cwahbong@...gle.com>
> > Reviewed-by: Todd Poynor <toddpoynor@...gle.com>
> > ---
> >  include/trace/events/workqueue.h | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/include/trace/events/workqueue.h
b/include/trace/events/workqueue.h
> > index 2f057a494d93..9a761bc6a251 100644
> > --- a/include/trace/events/workqueue.h
> > +++ b/include/trace/events/workqueue.h
> > @@ -25,6 +25,8 @@ DECLARE_EVENT_CLASS(workqueue_work,
> >       TP_printk("work struct %p", __entry->work)
> >  );
> >
> > +struct pool_workqueue;
> > +
> >  /**
> >   * workqueue_queue_work - called when a work gets queued
> >   * @req_cpu: the requested cpu